Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 191922cd authored by Johannes Berg's avatar Johannes Berg
Browse files

mac80211: clarify alignment comment



The comment says something about __skb_push(), but that
isn't even called in the code any more. Looking at the
git history, that comment never even made sense when it
was still called, so just replace that part to note it
still works even when align isn't 0 or 2.

Reported-by: default avatarEric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent 9fed3096
Loading
Loading
Loading
Loading
+4 −2
Original line number Diff line number Diff line
@@ -1894,8 +1894,10 @@ ieee80211_deliver_skb(struct ieee80211_rx_data *rx)
		 * 'align' will only take the values 0 or 2 here
		 * since all frames are required to be aligned
		 * to 2-byte boundaries when being passed to
		 * mac80211. That also explains the __skb_push()
		 * below.
		 * mac80211; the code here works just as well if
		 * that isn't true, but mac80211 assumes it can
		 * access fields as 2-byte aligned (e.g. for
		 * compare_ether_addr)
		 */
		align = ((unsigned long)(skb->data + sizeof(struct ethhdr))) & 3;
		if (align) {