Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 185de09c authored by David Howells's avatar David Howells
Browse files

X.509: x509_request_asymmetric_keys() doesn't need string length arguments 



x509_request_asymmetric_keys() doesn't need the lengths of the NUL-terminated
strings passing in as it can work that out for itself.

Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
Acked-by: default avatarMimi Zohar <zohar@linux.vnet.ibm.com>
parent 63d2551e

crypto/asymmetric_keys/x509_public_key.c

+3 −6
Original line number Diff line number Diff line
@@ -48,11 +48,10 @@ __setup("ca_keys=", ca_keys_setup); 
 */

static struct key *x509_request_asymmetric_key(struct key *keyring,

					       const char *signer,

					       size_t signer_len,

					       const char *authority,

					       size_t auth_len)

					       const char *authority)

{

	key_ref_t key;

	size_t signer_len = strlen(signer), auth_len = strlen(authority);

	char *id;



	/* Construct an identifier. */
@@ -193,9 +192,7 @@ static int x509_validate_trust(struct x509_certificate *cert, 
		return -EPERM;



	key = x509_request_asymmetric_key(trust_keyring,

					  cert->issuer, strlen(cert->issuer),

					  cert->authority,

					  strlen(cert->authority));

					  cert->issuer, cert->authority);

	if (!IS_ERR(key))  {

		if (!use_builtin_keys

		    || test_bit(KEY_FLAG_BUILTIN, &key->flags))