Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 182c515f authored by Oleg Nesterov's avatar Oleg Nesterov Committed by Linus Torvalds
Browse files

coredump: elf_fdpic_core_dump: use core_state->dumper list 



Kill the nasty rcu_read_lock() + do_each_thread() loop, use the list
encoded in mm->core_state instead, s/GFP_ATOMIC/GFP_KERNEL/.

This patch allows futher cleanups in binfmt_elf_fdpic.c.

Signed-off-by: default avatarOleg Nesterov <oleg@tv-sign.ru>
Acked-by: default avatarRoland McGrath <roland@redhat.com>
Cc: David Howells <dhowells@redhat.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 83914441

fs/binfmt_elf_fdpic.c

+12 −17
Original line number Diff line number Diff line
@@ -1573,7 +1573,6 @@ static int elf_fdpic_core_dump(long signr, struct pt_regs *regs, 
	struct memelfnote *notes = NULL;

	struct elf_prstatus *prstatus = NULL;	/* NT_PRSTATUS */

	struct elf_prpsinfo *psinfo = NULL;	/* NT_PRPSINFO */

 	struct task_struct *g, *p;

 	LIST_HEAD(thread_list);

 	struct list_head *t;

	elf_fpregset_t *fpu = NULL;
@@ -1622,23 +1621,19 @@ static int elf_fdpic_core_dump(long signr, struct pt_regs *regs, 
#endif



	if (signr) {

		struct core_thread *ct;

		struct elf_thread_status *tmp;

		rcu_read_lock();

		do_each_thread(g,p)

			if (current->mm == p->mm && current != p) {

				if (p->flags & PF_KTHREAD)

					continue;



				tmp = kzalloc(sizeof(*tmp), GFP_ATOMIC);

				if (!tmp) {

					rcu_read_unlock();

		for (ct = current->mm->core_state->dumper.next;

						ct; ct = ct->next) {

			tmp = kzalloc(sizeof(*tmp), GFP_KERNEL);

			if (!tmp)

				goto cleanup;

				}

				tmp->thread = p;



			tmp->thread = ct->task;

			list_add(&tmp->list, &thread_list);

		}

		while_each_thread(g,p);

		rcu_read_unlock();



		list_for_each(t, &thread_list) {

			struct elf_thread_status *tmp;

			int sz;