Commit 167c4265 authored Feb 13, 2008 by Jack Morgenstein Committed by Roland Dreier Feb 14, 2008

IPoIB: On P_Key change event, reset state properly



In P_Key event handling, if the old P_Key is no longer available, the
driver must call ipoib_ib_dev_stop() -- just as it does when the P_Key
is still available (see procedure __ipoib_ib_dev_flush()).

When a P_Key becomes available, the driver will perform ipoib_open(),
which assumes that the QP is in RESET, the cm_id has been
destroyed/deleted, etc.  If ipoib_ib_dev_stop() is not called as
described above, then these assumptions will be false, and the attempt
to bring the interface up will fail.

Found by Mellanox QA.

Signed-off-by: Jack Morgenstein <jackm@dev.mellanox.co.il>
Signed-off-by: Roland Dreier <rolandd@cisco.com>

parent 5163dc1a

drivers/infiniband/ulp/ipoib/ipoib_ib.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -780,6 +780,7 @@ static void __ipoib_ib_dev_flush(struct ipoib_dev_priv *priv, int pkey_event)
		if (ib_find_pkey(priv->ca, priv->port, priv->pkey, &new_index)) {
		clear_bit(IPOIB_PKEY_ASSIGNED, &priv->flags);
		ipoib_ib_dev_down(dev, 0);
		ipoib_ib_dev_stop(dev, 0);
		ipoib_pkey_dev_delay_open(dev);
		return;
		}