Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1621dbbd authored by Andrew Vasquez's avatar Andrew Vasquez Committed by James Bottomley
Browse files

[SCSI] qla2xxx: Return DID_NO_CONNECT when FC device is lost. 



If the target device gets lost, this fix is needed, as it causes
negative unintended responses on basic I/O tests. If the target device
gets lost, the upstream qla2xxx driver returns
SCSI_MLQUEUE_TARGET_BUSY which causes an immediate retry without drop
in the number of allowed retries. This semantic change, as a result of
removing FC_DEVICE_LOST check is reasonable, as it only extends a
short transitional period, until the transport is called to notify
that the rport as lost (fc_remote_port_delete()). Once transport
notification is done, fc_remote_port_chkready() check will take over.

Signed-off-by: default avatarAndrew Vasquez <andrew.vasquez@qlogic.com>
Signed-off-by: default avatarMadhuranath Iyengar <Madhu.Iyengar@qlogic.com>
Signed-off-by: default avatarJames Bottomley <James.Bottomley@suse.de>
parent d2b21476

drivers/scsi/qla2xxx/qla_os.c

+0 −1
Original line number Diff line number Diff line
@@ -562,7 +562,6 @@ qla2xxx_queuecommand_lck(struct scsi_cmnd *cmd, void (*done)(struct scsi_cmnd *) 
	}

	if (atomic_read(&fcport->state) != FCS_ONLINE) {

		if (atomic_read(&fcport->state) == FCS_DEVICE_DEAD ||

			atomic_read(&fcport->state) == FCS_DEVICE_LOST ||

			atomic_read(&base_vha->loop_state) == LOOP_DEAD) {

			cmd->result = DID_NO_CONNECT << 16;

			goto qc24_fail_command;