Commit 1601de35 authored Sep 13, 2022 by Nathan Huckleberry Committed by Greg Kroah-Hartman Nov 25, 2022

drm/imx: imx-tve: Fix return type of imx_tve_connector_mode_valid



[ Upstream commit fc007fb815ab5395c3962c09b79a1630b0fbed9c ]

The mode_valid field in drm_connector_helper_funcs is expected to be of
type:
enum drm_mode_status (* mode_valid) (struct drm_connector *connector,
                                     struct drm_display_mode *mode);

The mismatched return type breaks forward edge kCFI since the underlying
function definition does not match the function hook definition.

The return type of imx_tve_connector_mode_valid should be changed from
int to enum drm_mode_status.

Reported-by: Dan Carpenter <error27@gmail.com>
Link: https://github.com/ClangBuiltLinux/linux/issues/1703


Cc: llvm@lists.linux.dev
Signed-off-by: Nathan Huckleberry <nhuck@google.com>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20220913205544.155106-1-nhuck@google.com


Signed-off-by: Sasha Levin <sashal@kernel.org>

parent e126f71f

drivers/gpu/drm/imx/imx-tve.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -254,7 +254,8 @@ static int imx_tve_connector_get_modes(struct drm_connector *connector)
		return ret;
		}

		static int imx_tve_connector_mode_valid(struct drm_connector *connector,
		static enum drm_mode_status
		imx_tve_connector_mode_valid(struct drm_connector *connector,
		struct drm_display_mode *mode)
		{
		struct imx_tve *tve = con_to_tve(connector);