Commit 15aa793d authored Apr 03, 2018 by Tudor-Dan Ambarus Committed by Greg Kroah-Hartman Aug 03, 2018

crypto: authenc - don't leak pointers to authenc keys



[ Upstream commit ad2fdcdf75d169e7a5aec6c7cb421c0bec8ec711 ]

In crypto_authenc_setkey we save pointers to the authenc keys in
a local variable of type struct crypto_authenc_keys and we don't
zeroize it after use. Fix this and don't leak pointers to the
authenc keys.

Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 6b4cdfa0

crypto/authenc.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -108,6 +108,7 @@ static int crypto_authenc_setkey(struct crypto_aead authenc, const u8 key,
		CRYPTO_TFM_RES_MASK);

		out:
		memzero_explicit(&keys, sizeof(keys));
		return err;

		badkey: