Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 156e3c21 authored by Karicheri, Muralidharan's avatar Karicheri, Muralidharan Committed by David S. Miller
Browse files

net: netcp: remove dead code from the driver 



netcp_core is the first driver that will get initialized and the modules
(ethss, pa etc) will then get initialized. So the code at the end of
netcp_probe() that iterate over the modules is a dead code as the module
list will be always be empty. So remove this code.

Signed-off-by: default avatarMurali Karicheri <m-karicheri2@ti.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 8c85151d

drivers/net/ethernet/ti/netcp_core.c

+0 −9
Original line number Diff line number Diff line
@@ -2040,7 +2040,6 @@ static int netcp_probe(struct platform_device *pdev) 
	struct device_node *child, *interfaces;

	struct netcp_device *netcp_device;

	struct device *dev = &pdev->dev;

	struct netcp_module *module;

	int ret;



	if (!node) {
@@ -2087,14 +2086,6 @@ static int netcp_probe(struct platform_device *pdev) 
	/* Add the device instance to the list */

	list_add_tail(&netcp_device->device_list, &netcp_devices);



	/* Probe & attach any modules already registered */

	mutex_lock(&netcp_modules_lock);

	for_each_netcp_module(module) {

		ret = netcp_module_probe(netcp_device, module);

		if (ret < 0)

			dev_err(dev, "module(%s) probe failed\n", module->name);

	}

	mutex_unlock(&netcp_modules_lock);

	return 0;



probe_quit_interface: