Commit 1513069e authored Jul 27, 2015 by Alexander Duyck Committed by David S. Miller Jul 27, 2015

fib_trie: Drop unnecessary calls to leaf_pull_suffix



It was reported that update_suffix was taking a long time on systems where
a large number of leaves were attached to a single node.  As it turns out
fib_table_flush was calling update_suffix for each leaf that didn't have all
of the aliases stripped from it.  As a result, on this large node removing
one leaf would result in us calling update_suffix for every other leaf on
the node.

The fix is to just remove the calls to leaf_pull_suffix since they are
redundant as we already have a call in resize that will go through and
update the suffix length for the node before we exit out of
fib_table_flush or fib_table_flush_external.

Reported-by: David Ahern <dsa@cumulusnetworks.com>
Signed-off-by: Alexander Duyck <alexander.h.duyck@redhat.com>
Tested-by: David Ahern <dsa@cumulusnetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 7a6e0706

net/ipv4/fib_trie.c

+0 −4

Original line number	Diff line number	Diff line
		@@ -1793,8 +1793,6 @@ void fib_table_flush_external(struct fib_table *tb)
		if (hlist_empty(&n->leaf)) {
		put_child_root(pn, n->key, NULL);
		node_free(n);
		} else {
		leaf_pull_suffix(pn, n);
		}
		}
		}
		@@ -1864,8 +1862,6 @@ int fib_table_flush(struct fib_table *tb)
		if (hlist_empty(&n->leaf)) {
		put_child_root(pn, n->key, NULL);
		node_free(n);
		} else {
		leaf_pull_suffix(pn, n);
		}
		}