Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 147ec4d2 authored by Oleg Nesterov's avatar Oleg Nesterov Committed by Frederic Weisbecker
Browse files

x86: Make save_stack_address() !CONFIG_FRAME_POINTER friendly 



If CONFIG_FRAME_POINTER=n, print_context_stack() shouldn't neglect the
non-reliable addresses on stack, this is all we have if dump_trace(bp)
is called with the wrong or zero bp.

For example, /proc/pid/stack doesn't work if CONFIG_FRAME_POINTER=n.

This patch obviously has no effect if CONFIG_FRAME_POINTER=y, otherwise
it reverts 1650743c "x86: don't save unreliable stack trace entries".

Also, remove the unnecessary type-cast.

Signed-off-by: default avatarOleg Nesterov <oleg@redhat.com>
Cc: Roland McGrath <roland@redhat.com>
Cc: Arjan van de Ven <arjan@linux.intel.com>
Cc: Vegard Nossum <vegard.nossum@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Andrew Morton <akpm@linux-foundation.org>
LKML-Reference: <20100603193239.GA31530@redhat.com>
Signed-off-by: default avatarFrederic Weisbecker <fweisbec@gmail.com>
parent 039ca4e7

arch/x86/kernel/stacktrace.c

+5 −1
Original line number Diff line number Diff line
@@ -26,8 +26,10 @@ static int save_stack_stack(void *data, char *name) 
static void save_stack_address(void *data, unsigned long addr, int reliable)

{

	struct stack_trace *trace = data;

#ifdef CONFIG_FRAME_POINTER

	if (!reliable)

		return;

#endif

	if (trace->skip > 0) {

		trace->skip--;

		return;
@@ -39,9 +41,11 @@ static void save_stack_address(void *data, unsigned long addr, int reliable) 
static void

save_stack_address_nosched(void *data, unsigned long addr, int reliable)

{

	struct stack_trace *trace = (struct stack_trace *)data;

	struct stack_trace *trace = data;

#ifdef CONFIG_FRAME_POINTER

	if (!reliable)

		return;

#endif

	if (in_sched_functions(addr))

		return;

	if (trace->skip > 0) {