Commit 14513e49 authored Dec 07, 2017 by Shuah Khan Committed by Greg Kroah-Hartman Dec 20, 2017

usbip: fix stub_send_ret_submit() vulnerability to null transfer_buffer



commit be6123df1ea8f01ee2f896a16c2b7be3e4557a5a upstream.

stub_send_ret_submit() handles urb with a potential null transfer_buffer,
when it replays a packet with potential malicious data that could contain
a null buffer. Add a check for the condition when actual_length > 0 and
transfer_buffer is null.

Reported-by: Secunia Research <vuln@secunia.com>
Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent f3e95726

drivers/usb/usbip/stub_tx.c

+7 −0

Original line number	Diff line number	Diff line
		@@ -181,6 +181,13 @@ static int stub_send_ret_submit(struct stub_device *sdev)
		memset(&pdu_header, 0, sizeof(pdu_header));
		memset(&msg, 0, sizeof(msg));

		if (urb->actual_length > 0 && !urb->transfer_buffer) {
		dev_err(&sdev->udev->dev,
		"urb: actual_length %d transfer_buffer null\n",
		urb->actual_length);
		return -1;
		}

		if (usb_pipetype(urb->pipe) == PIPE_ISOCHRONOUS)
		iovnum = 2 + urb->number_of_packets;
		else