Commit 12cc8400 authored Oct 07, 2011 by Ashish Sharma Committed by Amit Pundir Aug 08, 2016

bridge: Have tx_bytes count headers like rx_bytes.



Since rx_bytes accounting does not include Ethernet Headers in
br_input.c, excluding ETH_HLEN on the transmit path for consistent
measurement of packet length on both the Tx and Rx chains.

The clean way would be for Rx to include the eth header, but the
skb len has already been adjusted by the time the br code sees the skb.
This is only a temporary workaround until we can completely ignore or
cleanly fix the skb->len handling.

Change-Id: I910de95a4686b2119da7f1f326e2154ef31f9972
Signed-off-by: Ashish Sharma <ashishsharma@google.com>

parent 6fd582e2

net/bridge/br_device.c

+6 −5

Original line number	Diff line number	Diff line
		@@ -48,16 +48,17 @@ netdev_tx_t br_dev_xmit(struct sk_buff skb, struct net_device dev)
		return NETDEV_TX_OK;
		}

		u64_stats_update_begin(&brstats->syncp);
		brstats->tx_packets++;
		brstats->tx_bytes += skb->len;
		u64_stats_update_end(&brstats->syncp);

		BR_INPUT_SKB_CB(skb)->brdev = dev;

		skb_reset_mac_header(skb);
		skb_pull(skb, ETH_HLEN);

		u64_stats_update_begin(&brstats->syncp);
		brstats->tx_packets++;
		/* Exclude ETH_HLEN from byte stats for consistency with Rx chain */
		brstats->tx_bytes += skb->len;
		u64_stats_update_end(&brstats->syncp);

		if (!br_allowed_ingress(br, br_vlan_group_rcu(br), skb, &vid))
		goto out;