Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 121c3a39 authored by Jack Pham's avatar Jack Pham Committed by Amit Pundir
Browse files

usb: dual-role: make stub functions inline 



If CONFIG_DUAL_ROLE_USB_INTF is disabled but the exported functions
are referenced, the build will result in warnings such as:

	In file included from include/linux/usb/class-dual-role.h:112:13:
	warning: ‘dual_role_instance_changed’ defined but not used
	[-Wunused-function]

These stub functions should be static inline.

Change-Id: I5a9ef58dca32306fac5a4c7f28cdaa36fa8ae078
Signed-off-by: default avatarJack Pham <jackp@codeaurora.org>
(cherry picked from commit 2d152dbb0743526b21d6bbefe097f874c027f860)
(cherry picked from commit 8ad66cafaa10e6ba94ff79a8dbc2cc437c6bfe93)
parent 7fbe4dde

include/linux/usb/class-dual-role.h

+5 −4
Original line number Diff line number Diff line
@@ -109,18 +109,19 @@ extern int dual_role_property_is_writeable(struct dual_role_phy_instance 
					   enum dual_role_property prop);

extern void *dual_role_get_drvdata(struct dual_role_phy_instance *dual_role);

#else /* CONFIG_DUAL_ROLE_USB_INTF */

static void dual_role_instance_changed(struct dual_role_phy_instance

static inline void dual_role_instance_changed(struct dual_role_phy_instance

				       *dual_role){}

static struct dual_role_phy_instance *__must_check

static inline struct dual_role_phy_instance *__must_check

devm_dual_role_instance_register(struct device *parent,

				 const struct dual_role_phy_desc *desc)

{

	return ERR_PTR(-ENOSYS);

}

static void devm_dual_role_instance_unregister(struct device *dev,

static inline void devm_dual_role_instance_unregister(struct device *dev,

					       struct dual_role_phy_instance

					       *dual_role){}

static void *dual_role_get_drvdata(struct dual_role_phy_instance *dual_role)

static inline void *dual_role_get_drvdata(struct dual_role_phy_instance

		*dual_role)

{

	return ERR_PTR(-ENOSYS);

}