Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1206ff4f authored by Jussi Kivilinna's avatar Jussi Kivilinna Committed by John W. Linville
Browse files

zd1201: do not use stack as URB transfer_buffer 



Patch fixes zd1201 not to use stack as URB transfer_buffer. URB buffers need
to be DMA-able, which stack is not.

Patch is only compile tested.

Cc: stable@vger.kernel.org
Signed-off-by: default avatarJussi Kivilinna <jussi.kivilinna@iki.fi>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 4fec06a3

drivers/net/wireless/zd1201.c

+3 −1
Original line number Diff line number Diff line
@@ -98,10 +98,12 @@ static int zd1201_fw_upload(struct usb_device *dev, int apfw) 
		goto exit;



	err = usb_control_msg(dev, usb_rcvctrlpipe(dev, 0), 0x4,

	    USB_DIR_IN | 0x40, 0,0, &ret, sizeof(ret), ZD1201_FW_TIMEOUT);

	    USB_DIR_IN | 0x40, 0, 0, buf, sizeof(ret), ZD1201_FW_TIMEOUT);

	if (err < 0)

		goto exit;



	memcpy(&ret, buf, sizeof(ret));



	if (ret & 0x80) {

		err = -EIO;

		goto exit;