Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 119fc007 authored by Shawn Guo's avatar Shawn Guo Committed by David S. Miller
Browse files

net: fec: use managed function devm_gpio_request_one 



Using gpio_request_one will require the probe fail-out call gpio_free,
which is missing currently.  Change to use devm_gpio_request_one to
fix the problem.

Signed-off-by: default avatarShawn Guo <shawn.guo@linaro.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 5fa9c0fe

drivers/net/ethernet/freescale/fec.c

+2 −1
Original line number Diff line number Diff line
@@ -1513,7 +1513,8 @@ static void __devinit fec_reset_phy(struct platform_device *pdev) 
		return;



	phy_reset = of_get_named_gpio(np, "phy-reset-gpios", 0);

	err = gpio_request_one(phy_reset, GPIOF_OUT_INIT_LOW, "phy-reset");

	err = devm_gpio_request_one(&pdev->dev, phy_reset,

				    GPIOF_OUT_INIT_LOW, "phy-reset");

	if (err) {

		pr_debug("FEC: failed to get gpio phy-reset: %d\n", err);

		return;