Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 10746e47 authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Felix Blyakher
Browse files

xfs: switch to NOFS allocation under i_lock in xfs_attr_rmtval_set 



xfs_attr_rmtval_set is always called with i_lock held, and i_lock is taken
in reclaim context so all allocations under it must avoid recursions into
the filesystem.

Reported by the new reclaim context tracing in lockdep.

Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarFelix Blyakher <felixb@sgi.com>
Signed-off-by: default avatarFelix Blyakher <felixb@sgi.com>
parent 36fae17a

fs/xfs/xfs_attr.c

+2 −2
Original line number Diff line number Diff line
@@ -2141,8 +2141,8 @@ xfs_attr_rmtval_set(xfs_da_args_t *args) 
		dblkno = XFS_FSB_TO_DADDR(mp, map.br_startblock),

		blkcnt = XFS_FSB_TO_BB(mp, map.br_blockcount);



		bp = xfs_buf_get_flags(mp->m_ddev_targp, dblkno,

							blkcnt, XFS_BUF_LOCK);

		bp = xfs_buf_get_flags(mp->m_ddev_targp, dblkno, blkcnt,

				       XFS_BUF_LOCK | XBF_DONT_BLOCK);

		ASSERT(bp);

		ASSERT(!XFS_BUF_GETERROR(bp));