Commit 10238074 authored Mar 28, 2012 by Sachin Prabhu Committed by Steve French Apr 03, 2012

Remove unnecessary check for NULL in password parser



The password parser has an unnecessary check for a NULL value which
triggers warnings in source checking tools. The code contains artifacts
from the old parsing code which are no longer required.

Signed-off-by: Sachin Prabhu <sprabhu@redhat.com>
Reviewed-by: Jeff Layton <jlayton@redhat.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Steve French <sfrench@us.ibm.com>

parent 66189be7

fs/cifs/connect.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -1565,8 +1565,7 @@ cifs_parse_mount_options(const char mountdata, const char devname,

		/* Obtain the value string */
		value = strchr(data, '=');
		if (value != NULL)
		*value++ = '\0';
		value++;

		/* Set tmp_end to end of the string */
		tmp_end = (char *) value + strlen(value);