Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0facef7f authored by Darrick J. Wong's avatar Darrick J. Wong Committed by Dave Chinner
Browse files

xfs: in _attrlist_by_handle, copy the cursor back to userspace 



When we're iterating inode xattrs by handle, we have to copy the
cursor back to userspace so that a subsequent invocation actually
retrieves subsequent contents.

Signed-off-by: default avatarDarrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarDave Chinner <david@fromorbit.com>
parent f2bdfda9

fs/xfs/xfs_ioctl.c

+6 −0
Original line number Diff line number Diff line
@@ -387,6 +387,7 @@ xfs_attrlist_by_handle( 
{

	int			error = -ENOMEM;

	attrlist_cursor_kern_t	*cursor;

	struct xfs_fsop_attrlist_handlereq __user	*p = arg;

	xfs_fsop_attrlist_handlereq_t al_hreq;

	struct dentry		*dentry;

	char			*kbuf;
@@ -419,6 +420,11 @@ xfs_attrlist_by_handle( 
	if (error)

		goto out_kfree;



	if (copy_to_user(&p->pos, cursor, sizeof(attrlist_cursor_kern_t))) {

		error = -EFAULT;

		goto out_kfree;

	}



	if (copy_to_user(al_hreq.buffer, kbuf, al_hreq.buflen))

		error = -EFAULT;