Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0f9722e3 authored by Axel Lin's avatar Axel Lin Committed by Kishon Vijay Abraham I
Browse files

phy: exynos-dp-video: Kill exynos_dp_video_phy_pwr_isol function 



If IS_ERR(state->regs) the .probe fails.
So IS_ERR(state->regs) test in exynos_dp_video_phy_pwr_isol() is not necessary.
exynos_dp_video_phy_pwr_isol() simply does a regmap_update_bits() call now,
just call regmap_update_bits() instead and return proper return value.

Signed-off-by: default avatarAxel Lin <axel.lin@ingics.com>
Reviewed-by: default avatarSylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: default avatarKishon Vijay Abraham I <kishon@ti.com>
parent af69decc

drivers/phy/phy-exynos-dp-video.c

+4 −20
Original line number Diff line number Diff line
@@ -30,28 +30,13 @@ struct exynos_dp_video_phy { 
	const struct exynos_dp_video_phy_drvdata *drvdata;

};



static void exynos_dp_video_phy_pwr_isol(struct exynos_dp_video_phy *state,

							unsigned int on)

{

	unsigned int val;



	if (IS_ERR(state->regs))

		return;



	val = on ? 0 : EXYNOS5_PHY_ENABLE;



	regmap_update_bits(state->regs, state->drvdata->phy_ctrl_offset,

			   EXYNOS5_PHY_ENABLE, val);

}



static int exynos_dp_video_phy_power_on(struct phy *phy)

{

	struct exynos_dp_video_phy *state = phy_get_drvdata(phy);



	/* Disable power isolation on DP-PHY */

	exynos_dp_video_phy_pwr_isol(state, 0);



	return 0;

	return regmap_update_bits(state->regs, state->drvdata->phy_ctrl_offset,

				  EXYNOS5_PHY_ENABLE, EXYNOS5_PHY_ENABLE);

}



static int exynos_dp_video_phy_power_off(struct phy *phy)
@@ -59,9 +44,8 @@ static int exynos_dp_video_phy_power_off(struct phy *phy) 
	struct exynos_dp_video_phy *state = phy_get_drvdata(phy);



	/* Enable power isolation on DP-PHY */

	exynos_dp_video_phy_pwr_isol(state, 1);



	return 0;

	return regmap_update_bits(state->regs, state->drvdata->phy_ctrl_offset,

				  EXYNOS5_PHY_ENABLE, 0);

}



static struct phy_ops exynos_dp_video_phy_ops = {