Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0f566b20 authored by Michael Chan's avatar Michael Chan Committed by David S. Miller
Browse files

tg3: Fix race condition in tg3_get_stats64() 



Spinlock should be taken before checking for tp->hw_stats.

Signed-off-by: default avatarMichael Chan <mchan@broadcom.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 091f0ea3

drivers/net/ethernet/broadcom/tg3.c

+4 −2
Original line number Diff line number Diff line
@@ -12524,10 +12524,12 @@ static struct rtnl_link_stats64 *tg3_get_stats64(struct net_device *dev, 
{

	struct tg3 *tp = netdev_priv(dev);



	if (!tp->hw_stats)

	spin_lock_bh(&tp->lock);

	if (!tp->hw_stats) {

		spin_unlock_bh(&tp->lock);

		return &tp->net_stats_prev;

	}



	spin_lock_bh(&tp->lock);

	tg3_get_nstats(tp, stats);

	spin_unlock_bh(&tp->lock);