Commit 0ef977d8 authored Nov 20, 2019 by Andy Shevchenko Committed by Greg Kroah-Hartman Jan 04, 2020

fbtft: Make sure string is NULL terminated



[ Upstream commit 21f585480deb4bcf0d92b08879c35d066dfee030 ]

New GCC warns about inappropriate use of strncpy():

drivers/staging/fbtft/fbtft-core.c: In function ‘fbtft_framebuffer_alloc’:
drivers/staging/fbtft/fbtft-core.c:665:2: warning: ‘strncpy’ specified bound 16 equals destination size [-Wstringop-truncation]
  665 |  strncpy(info->fix.id, dev->driver->name, 16);
      |  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Later on the copy is being used with the assumption to be NULL terminated.
Make sure string is NULL terminated by switching to snprintf().

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20191120095716.26628-1-andriy.shevchenko@linux.intel.com


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent f0a38523

drivers/staging/fbtft/fbtft-core.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -766,7 +766,7 @@ struct fb_info fbtft_framebuffer_alloc(struct fbtft_display display,
		fbdefio->deferred_io = fbtft_deferred_io;
		fb_deferred_io_init(info);

		strncpy(info->fix.id, dev->driver->name, 16);
		snprintf(info->fix.id, sizeof(info->fix.id), "%s", dev->driver->name);
		info->fix.type = FB_TYPE_PACKED_PIXELS;
		info->fix.visual = FB_VISUAL_TRUECOLOR;
		info->fix.xpanstep = 0;