Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0ec5258d authored by Torsten Schenk's avatar Torsten Schenk Committed by Takashi Iwai
Browse files

ALSA: 6fire - Fix signedness bug 



Fixed remaining issues of the signedness bug discovered by Dan Carpenter.
A check was remaining that tests if unsigned rt->rate is >= 0.
Changed that so that rt->rate now consistently uses ARRAY_SIZE(rates)
as invalid rate value and not -1.

Signed-off-by: default avatarTorsten Schenk <torsten.schenk@zoho.com>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent e72888e9

sound/usb/6fire/pcm.c

+2 −2
Original line number Diff line number Diff line
@@ -395,12 +395,12 @@ static int usb6fire_pcm_open(struct snd_pcm_substream *alsa_sub) 
	alsa_rt->hw = pcm_hw;



	if (alsa_sub->stream == SNDRV_PCM_STREAM_PLAYBACK) {

		if (rt->rate >= 0)

		if (rt->rate < ARRAY_SIZE(rates))

			alsa_rt->hw.rates = rates_alsaid[rt->rate];

		alsa_rt->hw.channels_max = OUT_N_CHANNELS;

		sub = &rt->playback;

	} else if (alsa_sub->stream == SNDRV_PCM_STREAM_CAPTURE) {

		if (rt->rate >= 0)

		if (rt->rate < ARRAY_SIZE(rates))

			alsa_rt->hw.rates = rates_alsaid[rt->rate];

		alsa_rt->hw.channels_max = IN_N_CHANNELS;

		sub = &rt->capture;