Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0ea3186c authored by Amitkumar Karwar's avatar Amitkumar Karwar Committed by Kalle Valo
Browse files

mwifiex: fix NULL packet downloading issues 



This patch makes sure that skb is freed after downloading
NULL packet in error cases. Also, USB chipsets return
-EINPROGRESS after downloading packets, they are freed in
USB completion handler later. We will add missing change
to set tx_lock_flag for USB which blocks further packets.

Signed-off-by: default avatarAmitkumar Karwar <akarwar@marvell.com>
Signed-off-by: default avatarCathy Luo <cluo@marvell.com>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
parent 7a1f4e61

drivers/net/wireless/mwifiex/sta_tx.c

+7 −2
Original line number Diff line number Diff line
@@ -183,9 +183,13 @@ int mwifiex_send_null_packet(struct mwifiex_private *priv, u8 flags) 
	}

	switch (ret) {

	case -EBUSY:

		adapter->data_sent = true;

		/* Fall through FAILURE handling */

		dev_kfree_skb_any(skb);

		dev_err(adapter->dev, "%s: host_to_card failed: ret=%d\n",

			__func__, ret);

		adapter->dbg.num_tx_host_to_card_failure++;

		break;

	case -1:

		adapter->data_sent = false;

		dev_kfree_skb_any(skb);

		dev_err(adapter->dev, "%s: host_to_card failed: ret=%d\n",

			__func__, ret);
@@ -198,6 +202,7 @@ int mwifiex_send_null_packet(struct mwifiex_private *priv, u8 flags) 
		adapter->tx_lock_flag = true;

		break;

	case -EINPROGRESS:

		adapter->tx_lock_flag = true;

		break;

	default:

		break;