Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0e8ed479 authored by Michael Neuling's avatar Michael Neuling Committed by Paul Mackerras
Browse files

[PATCH] powerpc: RTC memory corruption 



We should be memset'ing the data we are pointing to, not the pointer
itself.  This is in an error path so we probably don't hit it much.

Signed-off-by: default avatarMichael Neuling <mikey@neuling.org>
Signed-off-by: default avatarPaul Mackerras <paulus@samba.org>
parent c6cb3b5f

arch/powerpc/kernel/rtas-rtc.c

+1 −1
Original line number Diff line number Diff line
@@ -52,7 +52,7 @@ void rtas_get_rtc_time(struct rtc_time *rtc_tm) 
		error = rtas_call(rtas_token("get-time-of-day"), 0, 8, ret);

		if (error == RTAS_CLOCK_BUSY || rtas_is_extended_busy(error)) {

			if (in_interrupt() && printk_ratelimit()) {

				memset(&rtc_tm, 0, sizeof(struct rtc_time));

				memset(rtc_tm, 0, sizeof(struct rtc_time));

				printk(KERN_WARNING "error: reading clock"

				       " would delay interrupt\n");

				return;	/* delay not allowed */