Commit 0e0432f0 authored Jun 09, 2015 by Irina Tirdea Committed by Dmitry Torokhov Jun 09, 2015

Input: goodix - fix variable length array warning



Fix sparse warning:

drivers/input/touchscreen/goodix.c:182:26: warning: Variable length array is used.

Replace the variable length array with fixed length.

Some Goodix devices have maximum 5 touch points, while others have 10 touch
points. Using the maximum length (80 bytes) for all devices will lead to
wasting 40 bytes on stack when using devices with maximum 5 touch points.
However, that is preferable to using kmalloc which will use even more
resources.

Signed-off-by: Irina Tirdea <irina.tirdea@intel.com>
Acked-by: Bastien Nocera <hadess@hadess.net>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

parent 0dfb35bd

drivers/input/touchscreen/goodix.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -147,7 +147,7 @@ static void goodix_ts_report_touch(struct goodix_ts_data ts, u8 coor_data)
		*/
		static void goodix_process_events(struct goodix_ts_data *ts)
		{
		u8 point_data[1 + GOODIX_CONTACT_SIZE * ts->max_touch_num];
		u8 point_data[1 + GOODIX_CONTACT_SIZE * GOODIX_MAX_CONTACTS];
		int touch_num;
		int i;