Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0df213ca authored by Steven Rostedt's avatar Steven Rostedt Committed by Steven Rostedt
Browse files

ktest: Require one TEST_START in config file 



There has been too many times that I put in one too many SKIP
TEST_STARTs and start the test with the default randconfig by accident
that I added this to have ktest ask the user for which test they want to
run if no TEST_START is specified.

Now if I accidently start the test with all TEST_STARTs skipped, ktest
asks what test do I want to run, and I now have a chance to kill it
before it does a make mrproper on my build directory.

Signed-off-by: default avatarSteven Rostedt <rostedt@goodmis.org>
parent ddf607e5

tools/testing/ktest/ktest.pl

+11 −0
Original line number Original line Diff line number Diff line
@@ -345,6 +345,7 @@ sub read_config { 
    my $num_tests_set = 0;

    my $num_tests_set = 0;

    my $skip = 0;

    my $skip = 0;

    my $rest;

    my $rest;

    my $test_case = 0;





    while (<IN>) {

    while (<IN>) {
@@ -370,6 +371,7 @@ sub read_config { 
		$rest = $1;

		$rest = $1;

		$skip = 1;

		$skip = 1;

	    } else {

	    } else {

		$test_case = 1;

		$skip = 0;

		$skip = 0;

	    }

	    }
@@ -474,6 +476,15 @@ sub read_config { 
    # make sure we have all mandatory configs

    # make sure we have all mandatory configs

    get_ktest_configs;

    get_ktest_configs;





    # was a test specified?

    if (!$test_case) {

	print "No test case specified.\n";

	print "What test case would you like to run?\n";

	my $ans = <STDIN>;

	chomp $ans;

	$default{"TEST_TYPE"} = $ans;

    }



    # set any defaults

    # set any defaults





    foreach my $default (keys %default) {

    foreach my $default (keys %default) {