Commit 0deff99b authored Feb 28, 2021 by Dinghao Liu Committed by Greg Kroah-Hartman Jul 20, 2021

i40e: Fix error handling in i40e_vsi_open



[ Upstream commit 9c04cfcd4aad232e36306cdc5c74cd9fc9148a7e ]

When vsi->type == I40E_VSI_FDIR, we have caught the return value of
i40e_vsi_request_irq() but without further handling. Check and execute
memory clean on failure just like the other i40e_vsi_request_irq().

Fixes: 8a9eb7d3 ("i40e: rework fdir setup and teardown")
Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Tested-by: Tony Brelinski <tonyx.brelinski@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent eea7330d

drivers/net/ethernet/intel/i40e/i40e_main.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -5478,6 +5478,8 @@ int i40e_vsi_open(struct i40e_vsi *vsi)
		dev_driver_string(&pf->pdev->dev),
		dev_name(&pf->pdev->dev));
		err = i40e_vsi_request_irq(vsi, int_name);
		if (err)
		goto err_setup_rx;

		} else {
		err = -EINVAL;