Commit 0d4420a9 authored May 10, 2011 by Oliver Hartkopp Committed by David S. Miller May 10, 2011

slcan: fix ldisc->open retval



TTY layer expects 0 if the ldisc->open operation succeeded.

Reported-by: Matvejchikov Ilya <matvejchikov@gmail.com>
Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent aae1e743

drivers/net/can/slcan.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -583,7 +583,9 @@ static int slcan_open(struct tty_struct *tty)
		/* Done. We have linked the TTY line to a channel. */
		rtnl_unlock();
		tty->receive_room = 65536; /* We don't flow control */
		return sl->dev->base_addr;

		/* TTY layer expects 0 on success */
		return 0;

		err_free_chan:
		sl->tty = NULL;