Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0c6e617f authored by Cathy Avery's avatar Cathy Avery Committed by Bjorn Helgaas
Browse files

PCI: hv: Fix interrupt cleanup path 



SR-IOV disabled from the host causes a memory leak.  pci-hyperv usually
first receives a PCI_EJECT notification and then proceeds to delete the
hpdev list entry in hv_eject_device_work().  Later in hv_msi_free() since
the device is no longer on the device list hpdev is NULL and hv_msi_free
returns without freeing int_desc as part of hv_int_desc_free().

Signed-off-by: default avatarCathy Avery <cavery@redhat.com>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Acked-by: default avatarJake Oshins <jakeo@microsoft.com>
parent 837d741e

drivers/pci/host/pci-hyperv.c

+8 −6
Original line number Diff line number Diff line
@@ -732,16 +732,18 @@ static void hv_msi_free(struct irq_domain *domain, struct msi_domain_info *info, 


	pdev = msi_desc_to_pci_dev(msi);

	hbus = info->data;

	hpdev = get_pcichild_wslot(hbus, devfn_to_wslot(pdev->devfn));

	if (!hpdev)

	int_desc = irq_data_get_irq_chip_data(irq_data);

	if (!int_desc)

		return;



	int_desc = irq_data_get_irq_chip_data(irq_data);

	if (int_desc) {

	irq_data->chip_data = NULL;

		hv_int_desc_free(hpdev, int_desc);

	hpdev = get_pcichild_wslot(hbus, devfn_to_wslot(pdev->devfn));

	if (!hpdev) {

		kfree(int_desc);

		return;

	}



	hv_int_desc_free(hpdev, int_desc);

	put_pcichild(hpdev, hv_pcidev_ref_by_slot);

}