Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0c62fc6d authored by Nelson Elhage's avatar Nelson Elhage Committed by David S. Miller
Browse files

econet: Do the correct cleanup after an unprivileged SIOCSIFADDR. 



We need to drop the mutex and do a dev_put, so set an error code and break like
the other paths, instead of returning directly.

Signed-off-by: default avatarNelson Elhage <nelhage@ksplice.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 08338475

net/econet/af_econet.c

+4 −2
Original line number Diff line number Diff line
@@ -661,8 +661,10 @@ static int ec_dev_ioctl(struct socket *sock, unsigned int cmd, void __user *arg) 
	err = 0;

	switch (cmd) {

	case SIOCSIFADDR:

		if (!capable(CAP_NET_ADMIN))

			return -EPERM;

		if (!capable(CAP_NET_ADMIN)) {

			err = -EPERM;

			break;

		}



		edev = dev->ec_ptr;

		if (edev == NULL) {