Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0c055b34 authored by Takashi Iwai's avatar Takashi Iwai
Browse files

ALSA: hda - Fix the max length of control name in generic parser 



add_control_with_pfx() in hda_generic.c assumes a shorter name string
for the control element, and this resulted in the truncation of the
long but valid string like "Headphone Surround Switch" in the middle.

This patch aligns the max size to the actual limit of snd_ctl_elem_id,
44.

Cc: <stable@vger.kernel.org> [v3.9+]
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent cd6fb679

sound/pci/hda/hda_generic.c

+1 −1
Original line number Diff line number Diff line
@@ -854,7 +854,7 @@ static int add_control_with_pfx(struct hda_gen_spec *spec, int type, 
				const char *pfx, const char *dir,

				const char *sfx, int cidx, unsigned long val)

{

	char name[32];

	char name[44];

	snprintf(name, sizeof(name), "%s %s %s", pfx, dir, sfx);

	if (!add_control(spec, type, name, cidx, val))

		return -ENOMEM;