Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0be2136b authored by Ludovic Desroches's avatar Ludovic Desroches Committed by Vinod Koul
Browse files

dmaengine: at_xdmac: clean used descriptor 



When putting back a descriptor to the free descs list, some fields are
not set to 0, it can cause bugs if someone uses it without having this
in mind.
Descriptor are not put back one by one so it is easier to clean
descriptors when we request them.

Signed-off-by: default avatarLudovic Desroches <ludovic.desroches@atmel.com>
Cc: stable@vger.kernel.org #4.2
Signed-off-by: default avatarVinod Koul <vinod.koul@intel.com>
parent a1cf0903

drivers/dma/at_xdmac.c

+10 −1
Original line number Diff line number Diff line
@@ -455,6 +455,15 @@ static struct at_xdmac_desc *at_xdmac_alloc_desc(struct dma_chan *chan, 
	return desc;

}



void at_xdmac_init_used_desc(struct at_xdmac_desc *desc)

{

	memset(&desc->lld, 0, sizeof(desc->lld));

	INIT_LIST_HEAD(&desc->descs_list);

	desc->direction = DMA_TRANS_NONE;

	desc->xfer_size = 0;

	desc->active_xfer = false;

}



/* Call must be protected by lock. */

static struct at_xdmac_desc *at_xdmac_get_desc(struct at_xdmac_chan *atchan)

{
@@ -466,7 +475,7 @@ static struct at_xdmac_desc *at_xdmac_get_desc(struct at_xdmac_chan *atchan) 
		desc = list_first_entry(&atchan->free_descs_list,

					struct at_xdmac_desc, desc_node);

		list_del(&desc->desc_node);

		desc->active_xfer = false;

		at_xdmac_init_used_desc(desc);

	}



	return desc;