Commit 0ba7baee authored Nov 21, 2020 by Zhang Qilong Committed by Greg Kroah-Hartman Dec 29, 2020

soc: ti: knav_qmss: fix reference leak in knav_queue_probe



[ Upstream commit ec8684847d8062496c4619bc3fcff31c19d56847 ]

pm_runtime_get_sync will increment pm usage counter even it
failed. Forgetting to pm_runtime_put_noidle will result in
reference leak in knav_queue_probe, so we should fix it.

Fixes: 41f93af9 ("soc: ti: add Keystone Navigator QMSS driver")
Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
Signed-off-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent fc235191

drivers/soc/ti/knav_qmss_queue.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -1717,6 +1717,7 @@ static int knav_queue_probe(struct platform_device *pdev)
		pm_runtime_enable(&pdev->dev);
		ret = pm_runtime_get_sync(&pdev->dev);
		if (ret < 0) {
		pm_runtime_put_noidle(&pdev->dev);
		dev_err(dev, "Failed to enable QMSS\n");
		return ret;
		}