Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0ab56e20 authored by Troy Kisky's avatar Troy Kisky Committed by Jean Delvare
Browse files

i2c-davinci: Remove useless IVR read 



Interrupts are enabled at the point where the DAVINCI_I2C_IVR_REG is read,
so unless an interrupt happened just at that moment, no interrupt would be
pending. Even though documentation implies you should do this, I see no
reason. If slave support is added, this read would cause a hard to
reproduce bug.

Signed-off-by: default avatarTroy Kisky <troy.kisky@boundarydevices.com>
Signed-off-by: default avatarKevin Hilman <khilman@mvista.com>
Signed-off-by: default avatarJean Delvare <khali@linux-fr.org>
parent d868caa1

drivers/i2c/busses/i2c-davinci.c

+0 −4
Original line number Diff line number Diff line
@@ -240,7 +240,6 @@ i2c_davinci_xfer_msg(struct i2c_adapter *adap, struct i2c_msg *msg, int stop) 
	struct davinci_i2c_dev *dev = i2c_get_adapdata(adap);

	struct davinci_i2c_platform_data *pdata = dev->dev->platform_data;

	u32 flag;

	u32 stat;

	u16 w;

	int r;
@@ -264,9 +263,6 @@ i2c_davinci_xfer_msg(struct i2c_adapter *adap, struct i2c_msg *msg, int stop) 
	init_completion(&dev->cmd_complete);

	dev->cmd_err = 0;



	/* Clear any pending interrupts by reading the IVR */

	stat = davinci_i2c_read_reg(dev, DAVINCI_I2C_IVR_REG);



	/* Take I2C out of reset, configure it as master and set the

	 * start bit */

	flag = DAVINCI_I2C_MDR_IRS | DAVINCI_I2C_MDR_MST | DAVINCI_I2C_MDR_STT;