Commit 0a418269 authored Oct 22, 2013 by Peter Huewe

tpm: cleanup checkpatch warnings



before we rename the file it might be a good idea to cleanup the long
persisting checkpatch warnings.
Since everything is really trivial, splitting the patch up would only
result in noise.

For the interested reader - here the checkpatch warnings:
(regrouped for easer readability)

ERROR: trailing whitespace
+ * Specifications at www.trustedcomputinggroup.org^I $
+ * $
+^I/* $
+^I   parameters (RSA 12->bytes: keybit, #primes, expbit)  $

WARNING: unnecessary whitespace before a quoted newline
+			"invalid count value %x %zx \n", count, bufsiz);

ERROR: do not use assignment in if condition
+	if ((rc = chip->vendor.send(chip, (u8 *) buf, count)) < 0) {

ERROR: space required after that ',' (ctx:VxV)
+	len = tpm_transmit(chip,(u8 *) cmd, len);
 	                       ^

ERROR: "foo * bar" should be "foo *bar"
+ssize_t tpm_show_enabled(struct device * dev, struct device_attribute * attr,
+ssize_t tpm_show_enabled(struct device * dev, struct device_attribute * attr,
+ssize_t tpm_show_active(struct device * dev, struct device_attribute * attr,
+ssize_t tpm_show_active(struct device * dev, struct device_attribute * attr,
+ssize_t tpm_show_owned(struct device * dev, struct device_attribute * attr,
+ssize_t tpm_show_owned(struct device * dev, struct device_attribute * attr,
+ssize_t tpm_show_temp_deactivated(struct device * dev,
+				struct device_attribute * attr, char *buf)

WARNING: please, no space before tabs
+ * @chip_num: ^Itpm idx # or ANY$
+ * @res_buf: ^ITPM_PCR value$
+ * ^I^Isize of res_buf is 20 bytes (or NULL if you don't care)$
+ * @chip_num: ^Itpm idx # or AN&$
+ * @hash: ^Ihash value used to extend pcr value$

ERROR: code indent should use tabs where possible
+^I                                     TPM_ORD_CONTINUE_SELFTEST);$

WARNING: line over 80 characters
+static bool wait_for_tpm_stat_cond(struct tpm_chip *chip, u8 mask, bool check_cancel,

ERROR: trailing whitespace
+ * Called from tpm_<specific>.c probe function only for devices $

total: 16 errors, 7 warnings, 1554 lines checked

Signed-off-by: Peter Huewe <peterhuewe@gmx.de>

parent e907481b

drivers/char/tpm/tpm.c

+22 −22

Original line number	Diff line number	Diff line
		@@ -377,7 +377,8 @@ static ssize_t tpm_transmit(struct tpm_chip chip, const char buf,

		mutex_lock(&chip->tpm_mutex);

		if ((rc = chip->vendor.send(chip, (u8 *) buf, count)) < 0) {
		rc = chip->vendor.send(chip, (u8 *) buf, count);
		if (rc < 0) {
		dev_err(chip->dev,
		"tpm_transmit: tpm_send: error %zd\n", rc);
		goto out;
		@@ -847,8 +848,7 @@ int tpm_do_selftest(struct tpm_chip *chip)
		unsigned long duration;
		struct tpm_cmd_t cmd;

		duration = tpm_calc_ordinal_duration(chip,
		TPM_ORD_CONTINUE_SELFTEST);
		duration = tpm_calc_ordinal_duration(chip, TPM_ORD_CONTINUE_SELFTEST);

		loops = jiffies_to_msecs(duration) / delay_msec;

		@@ -1092,8 +1092,8 @@ ssize_t tpm_store_cancel(struct device dev, struct device_attribute attr,
		}
		EXPORT_SYMBOL_GPL(tpm_store_cancel);

		static bool wait_for_tpm_stat_cond(struct tpm_chip *chip, u8 mask, bool check_cancel,
		bool *canceled)
		static bool wait_for_tpm_stat_cond(struct tpm_chip *chip, u8 mask,
		bool check_cancel, bool *canceled)
		{
		u8 status = chip->vendor.status(chip);