Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 09a7636a authored by Dan Carpenter's avatar Dan Carpenter Committed by David S. Miller
Browse files

bnxt: fix a condition 



This code generates as static checker warning because htons(ETH_P_IPV6)
is always true.  From the context it looks like the && was intended to
be !=.

Fixes: 94758f8d ('bnxt_en: Add GRO logic for BCM5731X chips.')
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarMichael Chan <michael.chan@broadcom.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 606274c5

drivers/net/ethernet/broadcom/bnxt/bnxt.c

+1 −1
Original line number Diff line number Diff line
@@ -997,7 +997,7 @@ static struct sk_buff *bnxt_gro_func_5731x(struct bnxt_tpa_info *tpa_info, 
		 * correct protocol ID, it must be a loopback packet where

		 * the offsets are off by 4.

		 */

		if (proto != htons(ETH_P_IP) && proto && htons(ETH_P_IPV6))

		if (proto != htons(ETH_P_IP) && proto != htons(ETH_P_IPV6))

			loopback = true;

	}

	if (loopback) {