Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0977f273 authored by Jingoo Han's avatar Jingoo Han Committed by Wolfram Sang
Browse files

i2c: mxs: Use devm_ioremap_resource() 



Use devm_ioremap_resource() in order to make the code simpler,
and remove redundant return value check of platform_get_resource()
because the value is checked by devm_ioremap_resource().

Signed-off-by: default avatarJingoo Han <jg1.han@samsung.com>
Acked-by: default avatarShawn Guo <shawn.guo@linaro.org>
Acked-by: default avatarMarek Vasut <marex@denx.de>
Signed-off-by: default avatarWolfram Sang <wsa@the-dreams.de>
parent ae50b1df

drivers/i2c/busses/i2c-mxs.c

+6 −12
Original line number Diff line number Diff line
@@ -806,7 +806,6 @@ static int mxs_i2c_probe(struct platform_device *pdev) 
	struct mxs_i2c_dev *i2c;

	struct i2c_adapter *adap;

	struct resource *res;

	resource_size_t res_size;

	int err, irq;



	i2c = devm_kzalloc(dev, sizeof(struct mxs_i2c_dev), GFP_KERNEL);
@@ -819,18 +818,13 @@ static int mxs_i2c_probe(struct platform_device *pdev) 
	}



	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);

	irq = platform_get_irq(pdev, 0);



	if (!res || irq < 0)

		return -ENOENT;

	i2c->regs = devm_ioremap_resource(&pdev->dev, res);

	if (IS_ERR(i2c->regs))

		return PTR_ERR(i2c->regs);



	res_size = resource_size(res);

	if (!devm_request_mem_region(dev, res->start, res_size, res->name))

		return -EBUSY;



	i2c->regs = devm_ioremap_nocache(dev, res->start, res_size);

	if (!i2c->regs)

		return -EBUSY;

	irq = platform_get_irq(pdev, 0);

	if (irq < 0)

		return irq;



	err = devm_request_irq(dev, irq, mxs_i2c_isr, 0, dev_name(dev), i2c);

	if (err)