Commit 09424dab authored Sep 22, 2020 by Eric Biggers Committed by Greg Kroah-Hartman Nov 18, 2020

ext4: fix leaking sysfs kobject after failed mount

commit cb8d53d2c97369029cc638c9274ac7be0a316c75 upstream.

ext4_unregister_sysfs() only deletes the kobject.  The reference to it
needs to be put separately, like ext4_put_super() does.

This addresses the syzbot report
"memory leak in kobject_set_name_vargs (3)"
(https://syzkaller.appspot.com/bug?extid=9f864abad79fae7c17e1

).

Reported-by:  <syzbot+9f864abad79fae7c17e1@syzkaller.appspotmail.com>
Fixes: 72ba7450 ("ext4: release sysfs kobject when failing to enable quotas on mount")
Cc: stable@vger.kernel.org
Signed-off-by: Eric Biggers <ebiggers@google.com>
Link: https://lore.kernel.org/r/20200922162456.93657-1-ebiggers@kernel.org


Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
[sudip: adjust context]
Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 41ac66d1

fs/ext4/super.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -4336,6 +4336,7 @@ static int ext4_fill_super(struct super_block sb, void data, int silent)
		#ifdef CONFIG_QUOTA
		failed_mount8:
		ext4_unregister_sysfs(sb);
		kobject_put(&sbi->s_kobj);
		#endif
		failed_mount7:
		ext4_unregister_li_request(sb);