Commit 092be1d0 authored Oct 30, 2015 by Amit Pundir Committed by Dmitry Shmidt Jan 19, 2017

ANDROID: lowmemorykiller: use module_param_cb instead of __module_param_call



Use module_param_cb helper routine instead of
__module_param_call otherwise we run into following
build error:

  CC      drivers/staging/android/lowmemorykiller.o
drivers/staging/android/lowmemorykiller.c:293:28: error: macro "__module_param_call" requires 7 arguments, but only 6 given
       S_IRUGO | S_IWUSR, -1);
                            ^
drivers/staging/android/lowmemorykiller.c:290:1: warning: data definition has no type or storage class [enabled by default]
 __module_param_call(MODULE_PARAM_PREFIX, adj,
 ^
drivers/staging/android/lowmemorykiller.c:290:1: error: type defaults to ‘int’ in declaration of ‘__module_param_call’ [-Werror=implicit-int]
drivers/staging/android/lowmemorykiller.c:273:32: warning: ‘lowmem_adj_array_ops’ defined but not used [-Wunused-variable]
 static struct kernel_param_ops lowmem_adj_array_ops = {
                                ^
cc1: some warnings being treated as errors
make[3]: *** [drivers/staging/android/lowmemorykiller.o] Error 1

Change-Id: I9597d30626f71c39710ac06207e52868f602ee73
Signed-off-by: Amit Pundir <amit.pundir@linaro.org>

parent cbd47bd6

drivers/staging/android/lowmemorykiller.c

+3 −4

Original line number	Diff line number	Diff line
		@@ -289,10 +289,9 @@ static const struct kparam_array __param_arr_adj = {
		*/
		module_param_named(cost, lowmem_shrinker.seeks, int, 0644);
		#ifdef CONFIG_ANDROID_LOW_MEMORY_KILLER_AUTODETECT_OOM_ADJ_VALUES
		__module_param_call(MODULE_PARAM_PREFIX, adj,
		&lowmem_adj_array_ops,
		module_param_cb(adj, &lowmem_adj_array_ops,
		.arr = &__param_arr_adj,
		0644, -1);
		0644);
		__MODULE_PARM_TYPE(adj, "array of short");
		#else
		module_param_array_named(adj, lowmem_adj, short, &lowmem_adj_size, 0644);