Commit 0847ef88 authored Jul 30, 2015 by Kinglong Mee Committed by Trond Myklebust Aug 12, 2015

NFS: Remove duplicate svc_xprt_put from nfs41_callback_up



The xprt created by svc_create_xprt have be added to serv->sv_permsocks.
So putting the xprt directly is useless.
Otherwise, there is a more svc_xprt_put after the xprt be freed.

v2, same as v1.

Signed-off-by: Kinglong Mee <kinglongmee@gmail.com>
Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>

parent 5ef8d792

fs/nfs/callback.c

+0 −4

Original line number	Diff line number	Diff line
		@@ -162,10 +162,6 @@ nfs41_callback_up(struct svc_serv *serv)
		spin_lock_init(&serv->sv_cb_lock);
		init_waitqueue_head(&serv->sv_cb_waitq);
		rqstp = svc_prepare_thread(serv, &serv->sv_pools[0], NUMA_NO_NODE);
		if (IS_ERR(rqstp)) {
		svc_xprt_put(serv->sv_bc_xprt);
		serv->sv_bc_xprt = NULL;
		}
		dprintk("--> %s return %d\n", __func__, PTR_ERR_OR_ZERO(rqstp));
		return rqstp;
		}