Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 07e97ce1 authored by Yang Yingliang's avatar Yang Yingliang Committed by Greg Kroah-Hartman
Browse files

scsi: hpsa: Fix possible memory leak in hpsa_add_sas_device() 



[ Upstream commit fda34a5d304d0b98cc967e8763b52221b66dc202 ]

If hpsa_sas_port_add_rphy() returns an error, the 'rphy' allocated in
sas_end_device_alloc() needs to be freed. Address this by calling
sas_rphy_free() in the error path.

Fixes: d04e62b9 ("hpsa: add in sas transport class")
Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20221111043012.1074466-1-yangyingliang@huawei.com


Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent e744faa7

drivers/scsi/hpsa.c

+3 −1
Original line number Diff line number Diff line
@@ -9874,10 +9874,12 @@ static int hpsa_add_sas_device(struct hpsa_sas_node *hpsa_sas_node, 


	rc = hpsa_sas_port_add_rphy(hpsa_sas_port, rphy);

	if (rc)

		goto free_sas_port;

		goto free_sas_rphy;



	return 0;



free_sas_rphy:

	sas_rphy_free(rphy);

free_sas_port:

	hpsa_free_sas_port(hpsa_sas_port);

	device->sas_port = NULL;