Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 07e6619b authored by Arun Kumar Neelakantam's avatar Arun Kumar Neelakantam
Browse files

soc: qcom: msm_smd: check for NULL pointer and return 



Check for NULL pointer is present in WARN_ON() which prints message
and continue the execution.

Check and return the execution flow to avoid the NULL pointer
access.

CRs-Fixed: 2207243
Change-Id: I7d73762f3ead06afb97ddf762d9ea7f3fe466d26
Signed-off-by: default avatarArun Kumar Neelakantam <aneela@codeaurora.org>
parent ccf21f85

drivers/soc/qcom/msm_smd.c

+11 −9
Original line number Diff line number Diff line 
/* drivers/soc/qcom/msm_smd.c

 *

 * Copyright (C) 2007 Google, Inc.

 * Copyright (c) 2008-2017, The Linux Foundation. All rights reserved.

 * Copyright (c) 2008-2017, 2018, The Linux Foundation. All rights reserved.

 * Author: Brian Swetland <swetland@google.com>

 *

 * This software is licensed under the terms of the GNU General Public
@@ -269,11 +269,12 @@ static void *smd_memcpy32_to_fifo(void *dest, const void *src, size_t num_bytes) 
	uint32_t *dest_local = (uint32_t *)dest;

	uint32_t *src_local = (uint32_t *)src;



	if (WARN_ON(!dest_local || !src_local))

		return dest;

	WARN_ON(num_bytes & SMD_FIFO_ADDR_ALIGN_BYTES);

	WARN_ON(!dest_local ||

			((uintptr_t)dest_local & SMD_FIFO_ADDR_ALIGN_BYTES));

	WARN_ON(!src_local ||

			((uintptr_t)src_local & SMD_FIFO_ADDR_ALIGN_BYTES));

	WARN_ON(((uintptr_t)dest_local & SMD_FIFO_ADDR_ALIGN_BYTES));

	WARN_ON(((uintptr_t)src_local & SMD_FIFO_ADDR_ALIGN_BYTES));



	num_bytes /= sizeof(uint32_t);



	while (num_bytes--)
@@ -301,11 +302,12 @@ static void *smd_memcpy32_from_fifo(void *dest, const void *src, 
	uint32_t *dest_local = (uint32_t *)dest;

	uint32_t *src_local = (uint32_t *)src;



	if (WARN_ON(!dest_local || !src_local))

		return dest;

	WARN_ON(num_bytes & SMD_FIFO_ADDR_ALIGN_BYTES);

	WARN_ON(!dest_local ||

			((uintptr_t)dest_local & SMD_FIFO_ADDR_ALIGN_BYTES));

	WARN_ON(!src_local ||

			((uintptr_t)src_local & SMD_FIFO_ADDR_ALIGN_BYTES));

	WARN_ON(((uintptr_t)dest_local & SMD_FIFO_ADDR_ALIGN_BYTES));

	WARN_ON(((uintptr_t)src_local & SMD_FIFO_ADDR_ALIGN_BYTES));



	num_bytes /= sizeof(uint32_t);



	while (num_bytes--)