Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 06e21325 authored by Ido Schimmel's avatar Ido Schimmel Committed by Greg Kroah-Hartman
Browse files

mlxsw: core: Use variable timeout for EMAD retries 



[ Upstream commit 1f492eab67bced119a0ac7db75ef2047e29a30c6 ]

The driver sends Ethernet Management Datagram (EMAD) packets to the
device for configuration purposes and waits for up to 200ms for a reply.
A request is retried up to 5 times.

When the system is under heavy load, replies are not always processed in
time and EMAD transactions fail.

Make the process more robust to such delays by using exponential
backoff. First wait for up to 200ms, then retransmit and wait for up to
400ms and so on.

Fixes: caf7297e ("mlxsw: core: Introduce support for asynchronous EMAD register access")
Reported-by: default avatarDenis Yulevich <denisyu@nvidia.com>
Tested-by: default avatarDenis Yulevich <denisyu@nvidia.com>
Signed-off-by: default avatarIdo Schimmel <idosch@nvidia.com>
Reviewed-by: default avatarJiri Pirko <jiri@nvidia.com>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 808aaded

drivers/net/ethernet/mellanox/mlxsw/core.c

+1 −1
Original line number Diff line number Diff line
@@ -436,7 +436,7 @@ static void mlxsw_emad_trans_timeout_schedule(struct mlxsw_reg_trans *trans) 
{

	unsigned long timeout = msecs_to_jiffies(MLXSW_EMAD_TIMEOUT_MS);



	mlxsw_core_schedule_dw(&trans->timeout_dw, timeout);

	mlxsw_core_schedule_dw(&trans->timeout_dw, timeout << trans->retries);

}



static int mlxsw_emad_transmit(struct mlxsw_core *mlxsw_core,