Commit 06c8581f authored Feb 02, 2016 by Parthasarathy Bhuvaragan Committed by David S. Miller Feb 06, 2016

tipc: use alloc_ordered_workqueue() instead of WQ_UNBOUND w/ max_active = 1



Until now, tipc_rcv and tipc_send workqueues in server are allocated
with parameters WQ_UNBOUND & max_active = 1.
This parameters passed to this function makes it equivalent to
alloc_ordered_workqueue(). The later form is more explicit and
can inherit future ordered_workqueue changes.

In this commit we replace alloc_workqueue() with more readable
alloc_ordered_workqueue().

Acked-by: Ying Xue <ying.xue@windriver.com>
Reviewed-by: Jon Maloy <jon.maloy@ericsson.com>
Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvaragan@ericsson.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent ae245557

net/tipc/server.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -571,13 +571,13 @@ static void tipc_work_stop(struct tipc_server *s)

		static int tipc_work_start(struct tipc_server *s)
		{
		s->rcv_wq = alloc_workqueue("tipc_rcv", WQ_UNBOUND, 1);
		s->rcv_wq = alloc_ordered_workqueue("tipc_rcv", 0);
		if (!s->rcv_wq) {
		pr_err("can't start tipc receive workqueue\n");
		return -ENOMEM;
		}

		s->send_wq = alloc_workqueue("tipc_send", WQ_UNBOUND, 1);
		s->send_wq = alloc_ordered_workqueue("tipc_send", 0);
		if (!s->send_wq) {
		pr_err("can't start tipc send workqueue\n");
		destroy_workqueue(s->rcv_wq);