Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 06bdadd7 authored by AKASHI Takahiro's avatar AKASHI Takahiro Committed by Eric Paris
Browse files

audit: correct a type mismatch in audit_syscall_exit() 



audit_syscall_exit() saves a result of regs_return_value() in intermediate
"int" variable and passes it to __audit_syscall_exit(), which expects its
second argument as a "long" value.  This will result in truncating the
value returned by a system call and making a wrong audit record.

I don't know why gcc compiler doesn't complain about this, but anyway it
causes a problem at runtime on arm64 (and probably most 64-bit archs).

Signed-off-by: default avatarAKASHI Takahiro <takahiro.akashi@linaro.org>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Eric Paris <eparis@redhat.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarEric Paris <eparis@redhat.com>
parent 1ce319f1

include/linux/audit.h

+1 −1
Original line number Diff line number Diff line
@@ -137,7 +137,7 @@ static inline void audit_syscall_exit(void *pt_regs) 
{

	if (unlikely(current->audit_context)) {

		int success = is_syscall_success(pt_regs);

		int return_code = regs_return_value(pt_regs);

		long return_code = regs_return_value(pt_regs);



		__audit_syscall_exit(success, return_code);

	}