Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 06a5f877 authored by Liam Mark's avatar Liam Mark Committed by Vinayak Menon
Browse files

android/lowmemorykiller: Selectively count free CMA pages 



In certain memory configurations there can be a large number of
CMA pages which are not suitable to satisfy certain memory
requests.

This large number of unsuitable pages can cause the
lowmemorykiller to not kill any tasks because the
lowmemorykiller counts all free pages.
In order to ensure the lowmemorykiller properly evaluates the
free memory only count the free CMA pages if they are suitable
for satisfying the memory request.

Change-Id: I7f06d53e2d8cfe7439e5561fe6e5209ce73b1c90
Signed-off-by: default avatarLiam Mark <lmark@codeaurora.org>
Signed-off-by: default avatarVinayak Menon <vinmenon@codeaurora.org>
parent 7732e1d9

drivers/staging/android/lowmemorykiller.c

+74 −15
Original line number Diff line number Diff line
@@ -125,16 +125,47 @@ static int test_task_lmk_waiting(struct task_struct *p) 


static DEFINE_MUTEX(scan_mutex);



static int can_use_cma_pages(gfp_t gfp_mask)

{

	int can_use = 0;

	int mtype = gfpflags_to_migratetype(gfp_mask);

	int i = 0;

	int *mtype_fallbacks = get_migratetype_fallbacks(mtype);



	if (is_migrate_cma(mtype)) {

		can_use = 1;

	} else {

		for (i = 0;; i++) {

			int fallbacktype = mtype_fallbacks[i];



			if (is_migrate_cma(fallbacktype)) {

				can_use = 1;

				break;

			}



			if (fallbacktype == MIGRATE_TYPES)

				break;

		}

	}

	return can_use;

}



void tune_lmk_zone_param(struct zonelist *zonelist, int classzone_idx,

					int *other_free, int *other_file)

					int *other_free, int *other_file,

					int use_cma_pages)

{

	struct zone *zone;

	struct zoneref *zoneref;

	int zone_idx;



	for_each_zone_zonelist(zone, zoneref, zonelist, MAX_NR_ZONES) {

		if ((zone_idx = zonelist_zone_idx(zoneref)) == ZONE_MOVABLE)

		zone_idx = zonelist_zone_idx(zoneref);

		if (zone_idx == ZONE_MOVABLE) {

			if (!use_cma_pages && other_free)

				*other_free -=

				    zone_page_state(zone, NR_FREE_CMA_PAGES);

			continue;

		}



		if (zone_idx > classzone_idx) {

			if (other_free != NULL)
@@ -146,15 +177,25 @@ void tune_lmk_zone_param(struct zonelist *zonelist, int classzone_idx, 
					zone_page_state(zone,

					NR_ZONE_ACTIVE_FILE);

		} else if ((zone_idx < classzone_idx) && other_free) {

			if (zone_watermark_ok(zone, 0, 0, classzone_idx, 0))

			if (zone_watermark_ok(zone, 0, 0, classzone_idx, 0)) {

				if (!use_cma_pages) {

					*other_free -= min(

					  zone->lowmem_reserve[classzone_idx] +

					  zone_page_state(

					    zone, NR_FREE_CMA_PAGES),

					  zone_page_state(

					    zone, NR_FREE_PAGES));

				} else {

					*other_free -=

					  zone->lowmem_reserve[classzone_idx];

			else

				}

			} else {

				*other_free -=

					   zone_page_state(zone, NR_FREE_PAGES);

			}

		}

	}

}



void tune_lmk_param(int *other_free, int *other_file, struct shrink_control *sc)

{
@@ -164,6 +205,7 @@ void tune_lmk_param(int *other_free, int *other_file, struct shrink_control *sc) 
	struct zonelist *zonelist;

	enum zone_type high_zoneidx, classzone_idx;

	unsigned long balance_gap;

	int use_cma_pages;



	gfp_mask = sc->gfp_mask;

	zonelist = node_zonelist(0, gfp_mask);
@@ -171,6 +213,7 @@ void tune_lmk_param(int *other_free, int *other_file, struct shrink_control *sc) 
	zref = first_zones_zonelist(zonelist, high_zoneidx, NULL);

	preferred_zone = zref->zone;

	classzone_idx = zone_idx(preferred_zone);

	use_cma_pages = can_use_cma_pages(gfp_mask);



	balance_gap = min(low_wmark_pages(preferred_zone),

			  (preferred_zone->present_pages +
@@ -182,22 +225,38 @@ void tune_lmk_param(int *other_free, int *other_file, struct shrink_control *sc) 
			  balance_gap, 0, 0))) {

		if (lmk_fast_run)

			tune_lmk_zone_param(zonelist, classzone_idx, other_free,

				       other_file);

				       other_file, use_cma_pages);

		else

			tune_lmk_zone_param(zonelist, classzone_idx, other_free,

				       NULL);



		if (zone_watermark_ok(preferred_zone, 0, 0, _ZONE, 0))

				       NULL, use_cma_pages);



		if (zone_watermark_ok(preferred_zone, 0, 0, _ZONE, 0)) {

			if (!use_cma_pages) {

				*other_free -= min(

				  preferred_zone->lowmem_reserve[_ZONE]

				  + zone_page_state(

				    preferred_zone, NR_FREE_CMA_PAGES),

				  zone_page_state(

				    preferred_zone, NR_FREE_PAGES));

			} else {

				*other_free -=

				  preferred_zone->lowmem_reserve[_ZONE];

		else

			}

		} else {

			*other_free -= zone_page_state(preferred_zone,

						      NR_FREE_PAGES);

		}



		lowmem_print(4, "lowmem_shrink of kswapd tunning for highmem "

			     "ofree %d, %d\n", *other_free, *other_file);

	} else {

		tune_lmk_zone_param(zonelist, classzone_idx, other_free,

			       other_file);

			       other_file, use_cma_pages);



		if (!use_cma_pages) {

			*other_free -=

			  zone_page_state(preferred_zone, NR_FREE_CMA_PAGES);

		}



		lowmem_print(4, "lowmem_shrink tunning for others ofree %d, "

			     "%d\n", *other_free, *other_file);

include/linux/mmzone.h

+7 −0
Original line number Diff line number Diff line
@@ -65,6 +65,13 @@ enum { 


/* In mm/page_alloc.c; keep in sync also with show_migration_types() there */

extern char * const migratetype_names[MIGRATE_TYPES];

/*

 * Returns a list which contains the migrate types on to which

 * an allocation falls back when the free list for the migrate

 * type mtype is depleted.

 * The end of the list is delimited by the type MIGRATE_TYPES.

 */

extern int *get_migratetype_fallbacks(int mtype);



#ifdef CONFIG_CMA

#  define is_migrate_cma(migratetype) unlikely((migratetype) == MIGRATE_CMA)

mm/page_alloc.c

+5 −0
Original line number Diff line number Diff line
@@ -1832,6 +1832,11 @@ static int fallbacks[MIGRATE_TYPES][4] = { 
#endif

};



int *get_migratetype_fallbacks(int mtype)

{

	return fallbacks[mtype];

}



#ifdef CONFIG_CMA

static struct page *__rmqueue_cma_fallback(struct zone *zone,

					unsigned int order)