Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0682e690 authored by Neal Cardwell's avatar Neal Cardwell Committed by David S. Miller
Browse files

tcp: count packets marked lost for a TCP connection 



Count the number of packets that a TCP connection marks lost.

Congestion control modules can use this loss rate information for more
intelligent decisions about how fast to send.

Specifically, this is used in TCP BBR policer detection. BBR uses a
high packet loss rate as one signal in its policer detection and
policer bandwidth estimation algorithm.

The BBR policer detection algorithm cannot simply track retransmits,
because a retransmit can be (and often is) an indicator of packets
lost long, long ago. This is particularly true in a long CA_Loss
period that repairs the initial massive losses when a policer kicks
in.

Signed-off-by: default avatarVan Jacobson <vanj@google.com>
Signed-off-by: default avatarNeal Cardwell <ncardwell@google.com>
Signed-off-by: default avatarYuchung Cheng <ycheng@google.com>
Signed-off-by: default avatarNandita Dukkipati <nanditad@google.com>
Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Signed-off-by: default avatarSoheil Hassas Yeganeh <soheil@google.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent b2d3ea4a

include/linux/tcp.h

+1 −0
Original line number Diff line number Diff line
@@ -267,6 +267,7 @@ struct tcp_sock { 
				 * receiver in Recovery. */

	u32	prr_out;	/* Total number of pkts sent during Recovery. */

	u32	delivered;	/* Total data packets delivered incl. rexmits */

	u32	lost;		/* Total data packets lost incl. rexmits */



 	u32	rcv_wnd;	/* Current receiver window		*/

	u32	write_seq;	/* Tail(+1) of data held in tcp send buffer */

net/ipv4/tcp_input.c

+24 −1
Original line number Diff line number Diff line
@@ -899,12 +899,29 @@ static void tcp_verify_retransmit_hint(struct tcp_sock *tp, struct sk_buff *skb) 
		tp->retransmit_high = TCP_SKB_CB(skb)->end_seq;

}



/* Sum the number of packets on the wire we have marked as lost.

 * There are two cases we care about here:

 * a) Packet hasn't been marked lost (nor retransmitted),

 *    and this is the first loss.

 * b) Packet has been marked both lost and retransmitted,

 *    and this means we think it was lost again.

 */

static void tcp_sum_lost(struct tcp_sock *tp, struct sk_buff *skb)

{

	__u8 sacked = TCP_SKB_CB(skb)->sacked;



	if (!(sacked & TCPCB_LOST) ||

	    ((sacked & TCPCB_LOST) && (sacked & TCPCB_SACKED_RETRANS)))

		tp->lost += tcp_skb_pcount(skb);

}



static void tcp_skb_mark_lost(struct tcp_sock *tp, struct sk_buff *skb)

{

	if (!(TCP_SKB_CB(skb)->sacked & (TCPCB_LOST|TCPCB_SACKED_ACKED))) {

		tcp_verify_retransmit_hint(tp, skb);



		tp->lost_out += tcp_skb_pcount(skb);

		tcp_sum_lost(tp, skb);

		TCP_SKB_CB(skb)->sacked |= TCPCB_LOST;

	}

}
@@ -913,6 +930,7 @@ void tcp_skb_mark_lost_uncond_verify(struct tcp_sock *tp, struct sk_buff *skb) 
{

	tcp_verify_retransmit_hint(tp, skb);



	tcp_sum_lost(tp, skb);

	if (!(TCP_SKB_CB(skb)->sacked & (TCPCB_LOST|TCPCB_SACKED_ACKED))) {

		tp->lost_out += tcp_skb_pcount(skb);

		TCP_SKB_CB(skb)->sacked |= TCPCB_LOST;
@@ -1890,6 +1908,7 @@ void tcp_enter_loss(struct sock *sk) 
	struct sk_buff *skb;

	bool new_recovery = icsk->icsk_ca_state < TCP_CA_Recovery;

	bool is_reneg;			/* is receiver reneging on SACKs? */

	bool mark_lost;



	/* Reduce ssthresh if it has not yet been made inside this window. */

	if (icsk->icsk_ca_state <= TCP_CA_Disorder ||
@@ -1923,8 +1942,12 @@ void tcp_enter_loss(struct sock *sk) 
		if (skb == tcp_send_head(sk))

			break;



		mark_lost = (!(TCP_SKB_CB(skb)->sacked & TCPCB_SACKED_ACKED) ||

			     is_reneg);

		if (mark_lost)

			tcp_sum_lost(tp, skb);

		TCP_SKB_CB(skb)->sacked &= (~TCPCB_TAGBITS)|TCPCB_SACKED_ACKED;

		if (!(TCP_SKB_CB(skb)->sacked&TCPCB_SACKED_ACKED) || is_reneg) {

		if (mark_lost) {

			TCP_SKB_CB(skb)->sacked &= ~TCPCB_SACKED_ACKED;

			TCP_SKB_CB(skb)->sacked |= TCPCB_LOST;

			tp->lost_out += tcp_skb_pcount(skb);