Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 064403b1 authored by Keita Suzuki's avatar Keita Suzuki Committed by Greg Kroah-Hartman
Browse files

media: siano: fix memory leak of debugfs members in smsdvb_hotplug 



[ Upstream commit abf287eeff4c6da6aa804bbd429dfd9d0dfb6ea7 ]

When dvb_create_media_graph fails, the debugfs kept inside client should
be released. However, the current implementation does not release them.

Fix this by adding a new goto label to call smsdvb_debugfs_release.

Fixes: 0d3ab841 ("[media] dvb core: must check dvb_create_media_graph()")
Signed-off-by: default avatarKeita Suzuki <keitasuzuki.park@sslab.ics.keio.ac.jp>
Signed-off-by: default avatarSean Young <sean@mess.org>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 3ab6924c

drivers/media/common/siano/smsdvb-main.c

+4 −1
Original line number Diff line number Diff line
@@ -1180,12 +1180,15 @@ static int smsdvb_hotplug(struct smscore_device_t *coredev, 
	rc = dvb_create_media_graph(&client->adapter, true);

	if (rc < 0) {

		pr_err("dvb_create_media_graph failed %d\n", rc);

		goto client_error;

		goto media_graph_error;

	}



	pr_info("DVB interface registered.\n");

	return 0;



media_graph_error:

	smsdvb_debugfs_release(client);



client_error:

	dvb_unregister_frontend(&client->frontend);