Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0637c3cc authored by raghavendra ambadas's avatar raghavendra ambadas
Browse files

fbdev: msm: Fix unintialisation of variables 



The uninitialised variables in MDP driver can be accessed
with incorrect values. This change fixes the errors reported
in static analysis of MDP driver code.

Change-Id: I69193a1243d17dfb88e51717179e9f2ed2c4b5df
Signed-off-by: default avatarRaghavendra Ambadas <rambad@codeaurora.org>
parent 9bb342c0

drivers/video/fbdev/msm/mdss_dba_utils.c

+1 −2
Original line number Diff line number Diff line
@@ -734,7 +734,6 @@ void *mdss_dba_utils_init(struct mdss_dba_utils_init_data *uid) 
	struct mdss_dba_utils_data *udata = NULL;

	struct msm_dba_reg_info info;

	struct cec_abstract_init_data cec_abst_init_data;

	void *cec_abst_data;

	int ret = 0;



	if (!uid) {
@@ -823,7 +822,7 @@ void *mdss_dba_utils_init(struct mdss_dba_utils_init_data *uid) 
	udata->cec_abst_data = cec_abstract_init(&cec_abst_init_data);

	if (IS_ERR_OR_NULL(udata->cec_abst_data)) {

		pr_err("error initializing cec abstract module\n");

		ret = PTR_ERR(cec_abst_data);

		ret = PTR_ERR(udata->cec_abst_data);

		goto error;

	}

drivers/video/fbdev/msm/mdss_mdp_ctl.c

+1 −1
Original line number Diff line number Diff line
@@ -960,7 +960,7 @@ static u32 mdss_mdp_calc_prefill_line_time(struct mdss_mdp_ctl *ctl, 
{

	u32 prefill_us = 0;

	u32 prefill_amortized = 0;

	struct mdss_data_type *mdata;

	struct mdss_data_type *mdata = mdss_mdp_get_mdata();

	struct mdss_mdp_mixer *mixer;

	struct mdss_panel_info *pinfo;

	u32 fps, v_total;

drivers/video/fbdev/msm/mdss_mdp_overlay.c

+1 −1
Original line number Diff line number Diff line
@@ -1754,7 +1754,7 @@ static bool __is_roi_valid(struct mdss_mdp_pipe *pipe, 


int mdss_mode_switch(struct msm_fb_data_type *mfd, u32 mode)

{

	struct mdss_rect l_roi, r_roi;

	struct mdss_rect l_roi = {0}, r_roi = {0};

	struct mdss_mdp_ctl *ctl = mfd_to_ctl(mfd);

	struct mdss_overlay_private *mdp5_data = mfd_to_mdp5_data(mfd);

	struct mdss_mdp_ctl *sctl;