Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 05f4f1ab authored by Frans Klaver's avatar Frans Klaver Committed by Tony Lindgren
Browse files

ARM: OMAP3: vc: fix 'or' always true warning 



Fix the warning:
arch/arm/mach-omap2/vc.c:302:47: warning: logical ‘or’ of collectively exhaustive tests is always true [-Wlogical-op]

As we're toggling both CLKREQ and OFFMODE, we should also be checking
OFFMODE.

Signed-off-by: default avatarFrans Klaver <fransklaver@gmail.com>
Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
parent 874b300a

arch/arm/mach-omap2/vc.c

+1 −1
Original line number Diff line number Diff line
@@ -300,7 +300,7 @@ static void __init omap3_vc_init_pmic_signaling(struct voltagedomain *voltdm) 


	val = voltdm->read(OMAP3_PRM_POLCTRL_OFFSET);

	if (!(val & OMAP3430_PRM_POLCTRL_CLKREQ_POL) ||

	    (val & OMAP3430_PRM_POLCTRL_CLKREQ_POL)) {

	    (val & OMAP3430_PRM_POLCTRL_OFFMODE_POL)) {

		val |= OMAP3430_PRM_POLCTRL_CLKREQ_POL;

		val &= ~OMAP3430_PRM_POLCTRL_OFFMODE_POL;

		pr_debug("PM: fixing sys_clkreq and sys_off_mode polarity to 0x%x\n",